Skip to content

ENH: Vectorize model evaluation in mnist tutorial #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rossbar
Copy link
Collaborator

@rossbar rossbar commented Mar 12, 2021

The model is run against the test set at each epoch to evaluate performance. The evaluation step doesn't involve any sequential updates to the model itself, so it can be vectorized. The main benefits of the change are:

  1. Demonstrates NumPy features, primarily vectorization and reductions along axes
  2. Significantly improves the performance of the training/evaluation loop

This depends on #66 (includes some of the same commits), so marking as draft until #66 is merged.

@rossbar rossbar marked this pull request as draft March 12, 2021 05:35
@rossbar
Copy link
Collaborator Author

rossbar commented Mar 12, 2021

Note for reviewers: everything up to cabbdd1 is in #66. 22cc58c contains the relevant code changes if you want to review diffs in the mean time.

@rossbar
Copy link
Collaborator Author

rossbar commented Mar 16, 2021

I'm going to cherry-pick these commits over to #68 and close this in the interest of trying to get all of the performance enhancements into a single PR.

@rossbar rossbar closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant